Skip to content

Clarified documentation for kotlin compilation with maven plugin #4529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

mipo256
Copy link
Contributor

@mipo256 mipo256 commented Nov 6, 2024

The documentation for compilation of Kotlin projects along with Java code via Maven plugin is a bit obscure. The technique that is used is actually quite sophisticated, and it is not clear for an average reader why it works, why disabling native executions and re-declaring them, and why it is important to have kotlin plugin before maven compiler plugin.

To address this, I've contributed the detailed explanation about what is going on and why it works.

@mipo256 mipo256 requested a review from a team as a code owner November 6, 2024 11:34
@koshachy
Copy link
Collaborator

Hi @mipo256,

Thank you for your contribution to the Kotlin documentation! We really appreciate it.

Right now, the technical writing team is busy preparing for the upcoming Kotlin 2.1.0 release, so we won't be able to review your PR within the next two weeks. Apologies for the inconvenience.

We'll get back to your PR as soon as possible. In the meantime, it would be great if you could review the Kotlin documentation style guide and apply it to your contribution.

Thanks in advance, and we look forward to reviewing your changes!

Copy link
Contributor

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Dec 19, 2024
@koshachy koshachy removed the Stale label Dec 19, 2024
Copy link
Contributor

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Jan 19, 2025
@koshachy koshachy removed the Stale label Jan 21, 2025
Copy link
Contributor

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Feb 21, 2025
@mipo256
Copy link
Contributor Author

mipo256 commented Feb 21, 2025

Hey @koshachy, any updates on this?

@github-actions github-actions bot removed the Stale label Feb 22, 2025
Copy link
Contributor

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Mar 24, 2025
@koshachy koshachy removed the Stale label Mar 27, 2025
@koshachy
Copy link
Collaborator

Hey there,
Thanks again for your contribution!

We're currently working with the dev team to figure out the best way to incorporate the information you've provided. After that, we'll align it with our documentation guidelines and get it ready to merge.

Apologies for the delay — both the Technical Writing and Build Tools teams are currently focused on higher-priority tasks, but we’ll definitely come back to this PR. Hopefully, it won’t take too long.

Thanks again for your help!

@koshachy
Copy link
Collaborator

koshachy commented Apr 2, 2025

Hey @mipo256,

Thanks again for your contribution! I’ve used your clarification to update the entire Compile Kotlin and Java sources section in this PR: #4785

I’ll close this PR for now. If you have any further questions or suggestions, feel free to share them in the updated PR.

Cheers!

@koshachy koshachy closed this Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants