-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Clarified documentation for kotlin compilation with maven plugin #4529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @mipo256, Thank you for your contribution to the Kotlin documentation! We really appreciate it. Right now, the technical writing team is busy preparing for the upcoming Kotlin 2.1.0 release, so we won't be able to review your PR within the next two weeks. Apologies for the inconvenience. We'll get back to your PR as soon as possible. In the meantime, it would be great if you could review the Kotlin documentation style guide and apply it to your contribution. Thanks in advance, and we look forward to reviewing your changes! |
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
Hey @koshachy, any updates on this? |
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
Hey there, We're currently working with the dev team to figure out the best way to incorporate the information you've provided. After that, we'll align it with our documentation guidelines and get it ready to merge. Apologies for the delay — both the Technical Writing and Build Tools teams are currently focused on higher-priority tasks, but we’ll definitely come back to this PR. Hopefully, it won’t take too long. Thanks again for your help! |
The documentation for compilation of Kotlin projects along with Java code via Maven plugin is a bit obscure. The technique that is used is actually quite sophisticated, and it is not clear for an average reader why it works, why disabling native executions and re-declaring them, and why it is important to have kotlin plugin before maven compiler plugin.
To address this, I've contributed the detailed explanation about what is going on and why it works.